Skip to content

Disable chunkImportMap, fix #4137 - #4138

Merged
nstepien merged 1 commit into
mainfrom
fix-4137
Aug 18, 2026
Merged

Disable chunkImportMap, fix #4137#4138
nstepien merged 1 commit into
mainfrom
fix-4137

Conversation

@nstepien

Copy link
Copy Markdown
Collaborator

No description provided.

@nstepien nstepien self-assigned this Aug 18, 2026
@nstepien nstepien changed the title Disable chunkImportMap,, fix #4137 Disable chunkImportMap, fix #4137 Aug 18, 2026
@nstepien
nstepien marked this pull request as ready for review August 18, 2026 20:24
@nstepien
nstepien requested a review from amanmahajan7 as a code owner August 18, 2026 20:24
@nstepien
nstepien merged commit 5a8e030 into main Aug 18, 2026
2 checks passed
@nstepien
nstepien deleted the fix-4137 branch August 18, 2026 20:24
Comment thread package.json
],
"type": "module",
"sideEffects": [
"src/index.ts",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise this file does not get included in the build output for some reason.
Won't affect the lib since we don't publish src/index.ts

Comment thread vite.config.ts
clearScreen: false,
build: {
chunkImportMap: true,
// chunkImportMap: true,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the issue cause by this setting or sideEffects?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chunkImportMap was the issue, but claude also found the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants